Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the SearchIdentifier updateTime #755

Conversation

sfisher
Copy link
Contributor

@sfisher sfisher commented Oct 3, 2024

(and OpenSearch update_time) from link checker.

  1. only updates the db/opensearch if values are changed
  2. now OpenSearch link checker update takes the unix time in function signature
  3. updated tests to be correct for changed method in opensearch doc class

closes #752

…from link checker. !) only updates if changed, 2) now OS update takes the time, 3) updated test.
@sfisher sfisher requested a review from jsjiang October 3, 2024 19:55
@sfisher sfisher linked an issue Oct 3, 2024 that may be closed by this pull request
Copy link
Contributor

@jsjiang jsjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thank you Scott!

Jing

@jsjiang
Copy link
Contributor

jsjiang commented Oct 10, 2024

@sfisher Hi Scott, when performing merge please select the main branch instead of develop.
Thank you

Jing

@sfisher sfisher changed the base branch from main to develop October 21, 2024 20:12
@sfisher sfisher merged commit 5f93ef0 into develop Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update code to ensure sure updateTime updated w/ link checker
2 participants